Refactor snyk integrator for maximum reusability #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovemberTang
commented
Feb 23, 2024
| @@ -0,0 +1,138 @@ | |||
| import { randomBytes } from 'crypto'; | |||
There was a problem hiding this comment.
This file has just been moved from packages/snyk-integrator/src/pull-requests.ts. I'm not sure why GitHub hasn't picked that up
NovemberTang
commented
Feb 23, 2024
| export interface SnykIntegratorEvent { | ||
| name: string; | ||
| languages: string[]; | ||
| } | ||
|
|
||
| //GraphQL types for adding PRs to GitHub Projects |
There was a problem hiding this comment.
These types have moved here from the deleted file packages/snyk-integrator/src/types.ts
chrislomaxjones
approved these changes
Feb 23, 2024
NovemberTang
force-pushed
the
nt/dependency-graph-integrator
branch
from
9b8efd1 to
171325b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
common, so that it can be reused when we generate PRs to integrate scala projects with dependabotThe diff here is mostly changes to the lockfile, the code changes represent about 200 lines
Why?
We will be rolling out a workflow file across all scala repos that submits scala dependencies to GitHub, so dependabot can keep an eye on its vulnerabilities. We'll be doing this in much the same way as the Snyk integrator, so want to make this code a little more reusable.
How has it been verified?