Report own_peer address in HealthCheck method

[huikang]

• Why we need the new field in message HealthCheckResp

My understanding is that each instance in the gubernator cluster advertises an address to let peers find itself. This adverse address is included in a slice of PeerInfo. The instance must identify its own address in the PeerInfo slice.
However, since each instance may have two addresses GRPC_ADDRESS and Advertise_Address , a misconfiguration could lead the node fail to identify itself before calling SetPeers . Therefore, when we check the status of the cluster, it's helpful to know each peer has identified itself in the cluster by checking the list of peers.

This new field own_peer uses the adverse_address of the instance to match the address in the known peers.
If the instance doesn't identify itself in the peer list, the own_peer is empty, which may indicate there is some misconfiguration of the node.

Please correct me if my understanding is wrong. Thanks.

[thrawn01]

Thank you for this PR!

own_peer could be confusing without knowledge of the code and understanding what "own" or "owner" means in this context.

I suggest calling it advertise_address as that is slightly less confusing. 😄

I also suggested adding more detailed to the comment in order to clarify the intent of the new field.

[thrawn01]

If this address is empty, then we should set health.Status = UnHealthy

[huikang]

Thank you for this PR!

own_peer could be confusing without knowledge of the code and understanding what "own" or "owner" means in this context.

I suggest calling it advertise_address as that is slightly less confusing. 😄

I also suggested adding more detailed to the comment in order to clarify the intent of the new field.

Thanks for your feedback. I totally agreed with your suggestions. Will update the PR.

[huikang]

@thrawn01 , given the recent changes, shall we cut a minor release, 2.10.1?

[thrawn01]

New release https://github.com/gubernator-io/gubernator/releases/tag/v2.11.0