-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuing Implementation of #3692 - Second round of ConsoleDriver cleanup #3737
Closed
dodexahedron
wants to merge
126
commits into
gui-cs:v2_develop
from
dodexahedron:v2_d12_some_driver_cleanup_2
Closed
Continuing Implementation of #3692 - Second round of ConsoleDriver cleanup #3737
dodexahedron
wants to merge
126
commits into
gui-cs:v2_develop
from
dodexahedron:v2_d12_some_driver_cleanup_2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run formatting rules
Yay for code reduction!
Also categorize some tests that temporarily failed for bogus reasons I was in the files, so just went ahead and labeled them...
It's probably going away anyway.
Preparation to migrat WindowsConsole and WindowsDriver to the new form.
… use case. Already named as the ultimate name of the type, which hasn't been renamed just yet.
Helps ensure deterministic behavior when cross-compiling.
dodexahedron
added
enhancement
work-in-progress
Windows
design
Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...)
dependencies
Pull requests that update a dependency file
.NET
Pull requests that update .net code
v2
For discussions, issues, etc... relavant for v2
labels
Sep 12, 2024
(Usage not updated in this commit)
Closing this one, as well, for same reason mentioned in #3710 Will open new PRs when I have drafts or merge-ready stuff ready after some more drawing board time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
design
Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...)
enhancement
.NET
Pull requests that update .net code
v2
For discussions, issues, etc... relavant for v2
Windows
work-in-progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from the end of the branch in #3710, for #3692.
This one started off with me going after MainLoop, but quickly turned into working on the rest of the Windows driver implementations, in the WindowsDriver and WindowsConsole classes.
So, that's where it will continue to focus and what this one will be mostly contained to.
Note that the commit list and diffs show everything back to the start of #3710, but will reduce to starting at the end of #3710, once that is merged.
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)I pushed the branch in its state before I did more work, yesterday, when I was rebasing the other branch anyway. Not a whole lot to see, yet, though a couple of PInvokes have been jostled around a bit. Not to be considered stable at current head of this branch, at the moment. Was just a sync.
WIP