Porting client from fern-reporter to client repo #1
Conversation
client/go.mod
Outdated
| go 1.21.3 | ||
|
|
||
| require ( | ||
| github.com/guidewire/fern-reporter v0.0.0-20240202054108-9e68ab4107a7 |
There was a problem hiding this comment.
If we depend on fern-reporter we would still get all the transient dependencies. We should try to make this a standalone repo without any dependency on fern-reporter
There was a problem hiding this comment.
The dependency with fern-reporter is removed.
go.mod
Outdated
| go 1.21.3 | ||
|
|
||
| require ( | ||
| github.com/guidewire/fern-reporter v0.0.0-20240202054108-9e68ab4107a7 |
There was a problem hiding this comment.
We should not have a dependency on fern-reporter as it defeats the purpose and would be pulled in. We want the client to be independent
There was a problem hiding this comment.
Removed the dependency with fern reporter.
|
@anoop2811 The comments are addressed. Please review. |
There was a problem hiding this comment.
Good job. We will need to test this acceptance test in github actions. Perhaps you might want to add an issue wrt to that for this repo
There was a problem hiding this comment.
done. Created an issue #2
This PR copies the client files from the fern-reporter repo to the fern-ginko-client repo.