Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for Template Controller to check deletion #29

Conversation

katronquillo
Copy link
Collaborator

No description provided.

@katronquillo katronquillo force-pushed the test/template-integration-tests branch from 403168d to c684fad Compare October 24, 2024 17:14
@amirbavand
Copy link
Collaborator

Is there any reason for changing the file path?
Also the lint jobs are failing. Could you please fix the lint issue?

@katronquillo
Copy link
Collaborator Author

katronquillo commented Oct 27, 2024

@amirbavand I pushed changes that should fix the linter issue. As for changing the file paths, this was done to separate the apply for the input resources and the Templates. I wasn't aware that the examples were being used in the E2E tests though, so I'll sync up with you on how to run the other tests and then make the changes to revert this in a future commit.

@katronquillo katronquillo force-pushed the test/template-integration-tests branch from 9bfe348 to f4a7de2 Compare November 1, 2024 17:15
@katronquillo
Copy link
Collaborator Author

katronquillo commented Nov 1, 2024

The Go Coverage build for this PR is failing with 403 Forbidden when trying to publish the code coverage. I suspect this is because it was created from a forked repository. I've created a new PR with a feature branch on this repository and will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants