This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Update for React 0.13.x compatibility #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2015 11:20
- The "transferPropsTo" method is removed (it was deprecated in 0.12.x). - "componentDidMount" and "componentDidUpdate" no longer take the DOM element as a parameter. Instead, we need to use React.findDOMNode(this) to grab it ourselves.
The change to support React 0.13.x can be considered a breaking change, so we wouldn't want any one using "0.x" to be automatically updated to this version.
|
Hi @guillaumervls: Any chance of you being able to merge in the above changes? Thanks! |
If we don't match a whitespace the while loop shortening the text may
go into an infinite loop
Match either a characher or a whitespace.
added 5 commits
June 23, 2015 15:39
Mocha-based tests can be run using `require` and any CommonJS functionality. Browserify will then compile all these tests into a single file that can be included in the react-ellipsis.test.html test harness. The next step is to start writing actual tests.
Runs the tests whenever the pertinent files are changed.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @guillaumervls,
I wanted to use
react-ellipsisin a project I'm working on, and I found that the component wasn't compatible with React 0.13.x. Your code is extremely simple, so I went ahead and made some changes. It would be great if you could merge them in and publish a new version of the module!Please let me know if you have any questions about this.
Thanks for creating this module!