upgrade accord dependency #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accord depends on fobject. fobject depended on an old version of graceful-fs that wasn't compatible with node 6, but this has been fixed now in both fobject and accord. this is untested and submitted through the GH website, but should work fine?
This isn't released yet... but will be the next release that fixes this issue.
|
Note that this depends on an unreleased version of accord. The next release ^0.22.5 will have the fix I need in it. |
|
For reference... jescalan/accord#180 |
|
Please comment here when accord is published |
|
Will do. |
Closed
|
it has been released. |
|
merged a9a1f75 |
|
Thanks! |
|
published to v3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accord depends on fobject.
fobject depended on an old version of graceful-fs that wasn't compatible with node 6, but this has been fixed now in both fobject and accord.
this is untested and submitted through the GH website, but should work fine?