Merge pull request #542 from jdegenstein/dev

Update github actions to nodejs 20, and enable parallel execution where available in OCCT
gumyr · Feb 6, 2024 · 4641d1d · 4641d1d
2 parents f06f4fa + 2db88da
commit 4641d1d
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/.github/actions/setup-macos-arm64/action.yml b/.github/actions/setup-macos-arm64/action.yml
@@ -8,7 +8,7 @@ runs:
   using: "composite"
   steps:
     - name: python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: install requirements

diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
@@ -8,7 +8,7 @@ runs:
   using: "composite"
   steps:
     - name: python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
     - name: install requirements
@@ -18,4 +18,4 @@ runs:
         pip install mypy
         pip install pytest
         pip install pylint
-        pip install .
+        pip install .
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,7 @@ jobs:
 
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: ./.github/actions/setup/
         with:
           python-version: ${{ matrix.python-version }}
@@ -37,7 +37,7 @@ jobs:
 
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - uses: ./.github/actions/setup-macos-arm64/
         with:
           python-version: ${{ matrix.python-version }}

diff --git a/src/build123d/mesher.py b/src/build123d/mesher.py
@@ -275,7 +275,7 @@ def _mesh_shape(
             theLinDeflection=linear_deflection,
             isRelative=True,
             theAngDeflection=angular_deflection,
-            isInParallel=False,
+            isInParallel=True,
         )
 
         ocp_mesh_vertices = []

diff --git a/src/build123d/topology.py b/src/build123d/topology.py
@@ -1823,7 +1823,7 @@ def export_stl(
             bool: Success
         """
         mesh = BRepMesh_IncrementalMesh(
-            self.wrapped, tolerance, True, angular_tolerance
+            self.wrapped, tolerance, True, angular_tolerance, True
         )
         mesh.Perform()
 
@@ -1972,7 +1972,9 @@ def is_valid(self) -> bool:
         Returns:
 
         """
-        return BRepCheck_Analyzer(self.wrapped).IsValid()
+        chk = BRepCheck_Analyzer(self.wrapped)
+        chk.SetParallel(True)
+        return chk.IsValid()
 
     def bounding_box(self, tolerance: float = None) -> BoundBox:
         """Create a bounding box for this Shape.
@@ -2789,7 +2791,7 @@ def mesh(self, tolerance: float, angular_tolerance: float = 0.1):
         """
 
         if not BRepTools.Triangulation_s(self.wrapped, tolerance):
-            BRepMesh_IncrementalMesh(self.wrapped, tolerance, True, angular_tolerance)
+            BRepMesh_IncrementalMesh(self.wrapped, tolerance, True, angular_tolerance, True)
 
     def tessellate(
         self, tolerance: float, angular_tolerance: float = 0.1