-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example in Documentation (updated rev1) #490
Conversation
preparation for new helper scripts
thumbnail images, example images, two pytho n helper scipts
modified: examples/benchy.py new file: examples/benchy_v2024.py modified: examples/boxes_on_faces.py modified: examples/boxes_on_faces_algebra.py modified: examples/build123d_customizable_logo.py modified: examples/build123d_customizable_logo_algebra.py modified: examples/build123d_logo_algebra.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #490 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 24 24
Lines 7461 7461
=======================================
Hits 7171 7171
Misses 290 290 ☔ View full report in Codecov by Sentry. |
there is an there is a |
If I understand correctly, the With the benchy there are several images but it looks like only the first appears in docs. Since creation is done manually, I wonder if the extra work of creation is justified. What if we just start with the rst files and associated images contained in the PR? This should help get a feel for what the docs will look like and allow others to provide feedback. |
ok. I can remove the helper python scripts and the yaml files. About the Benchy you are right, I missed the example with more images - will be rectified. |
removed Python-scripts for documentation generatation,\n added missing benchy images in a gallery\n and removed information details that are too much for the user/reader
@gumyr followed your lead.
Content-wise Concepts
Process-wise Concepts
|
added the first three samples for the examples (example_1.rst)
docs/assets/examples
namedcreate_thumbnail_images.py
andcreate_rst.py