feat: create mesh in fewer iterations #868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gumyr thank you for this awesome library!
this PR includes some small changes to the meshing logic that greatly improve the export speed for a couple of toy projects I'm working on (300K+ vertices), and wanted to share it as it may be helpful to others.
with change
without change
additional this PR adds a small test to ensure that
100K
vertices always take less than 1 second.pytest tests/test_mesher.py -v # tests/test_mesher.py::InternalApiBenchmark::test_create_3mf_mesh PASSED
Please let me know if I should make any changes, and thanks again! 🙏