Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Axis.position and Axis.direction properties #905

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Feb 15, 2025

The .position and .direction members of the Axis class are currently copies made at initialization which means that they are modifiable but not kept in sync with the underlying .wrapped object.

axes = [Axis.Y for _ in range(10)]
for i, a in enumerate(axes):
    a.position += (i, 0, 0)  # translating each axis
show_all()  # all axes show at (0,0,0)

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (8b53e1a) to head (e0e5d0d).
Report is 12 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #905      +/-   ##
==========================================
+ Coverage   96.72%   96.73%   +0.01%     
==========================================
  Files          32       32              
  Lines        9339     9379      +40     
==========================================
+ Hits         9033     9073      +40     
  Misses        306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr gumyr merged commit ffc3eba into gumyr:dev Feb 18, 2025
20 checks passed
@gumyr
Copy link
Owner

gumyr commented Feb 18, 2025

Thank you!

@snoyer snoyer deleted the axis-props branch February 18, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants