add align parameter to import_svg
#908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #908 +/- ##
==========================================
- Coverage 96.73% 96.73% -0.01%
==========================================
Files 32 32
Lines 9379 9434 +55
==========================================
+ Hits 9073 9126 +53
- Misses 306 308 +2 ☔ View full report in Codecov by Sentry. |
|
Nice feature, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocpsvg >= 0.5now properly interprets the viewbox when importing SVG documents and PR takes advantage of this change to introduce analignparameter to theimport_svgfunction.The default is set to
align=Align.MINto keep the current import behavior of positioning the bottom left corner of the document at(0,0).align=Noneis allowed and can be used to preserve the viewbox origin.