-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Hey, thanks for the PR! |
Hi! The newly added tests are not supposed to cover #25. Those are just additional test scenarios which I recognized that they are not covered yet, while trying to implement a fix. The code for covering #25 would be the following: getValidTestCase(`
class Class1 {
/** @deprecated */ method() {};
}
class Class2 extends Class1 {
method() {};
}
new Class2().method();
`), This test case fails currently. Should I add this and comment it out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, no we don't need to add broken tests =)
I would also ask you to please add to your new test cases a one line comment to each explaining the use-case like in the other cases there.
Code Climate has analyzed commit ebed6f0 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! Looks good!
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.