Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

test: add more test cases #42

Merged
merged 4 commits into from
Dec 28, 2021
Merged

test: add more test cases #42

merged 4 commits into from
Dec 28, 2021

Conversation

json-derulo
Copy link
Contributor

No description provided.

@gund
Copy link
Owner

gund commented Dec 15, 2021

Hey, thanks for the PR!
If this is supposed to cover #25 then the tests should fail but why they are not failing?

@json-derulo
Copy link
Contributor Author

json-derulo commented Dec 15, 2021

Hey, thanks for the PR! If this is supposed to cover #25 then the tests should fail but why they are not failing?

Hi! The newly added tests are not supposed to cover #25. Those are just additional test scenarios which I recognized that they are not covered yet, while trying to implement a fix. The code for covering #25 would be the following:

getValidTestCase(`
  class Class1 {
    /** @deprecated */ method() {};
  }
  class Class2 extends Class1 {
    method() {};
  }
  new Class2().method();
`),

This test case fails currently. Should I add this and comment it out?

Copy link
Owner

@gund gund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, no we don't need to add broken tests =)
I would also ask you to please add to your new test cases a one line comment to each explaining the use-case like in the other cases there.

tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Outdated Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
tests/rules/deprecation.test.ts Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Dec 27, 2021

Code Climate has analyzed commit ebed6f0 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@gund gund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! Looks good!

@gund gund merged commit 658e8c3 into gund:master Dec 28, 2021
@gund
Copy link
Owner

gund commented Nov 14, 2022

🎉 This PR is included in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants