-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamlerhart Last Update: Disabling GC #636
Gamlerhart Last Update: Disabling GC #636
Conversation
Cuts off sometimes up to 1 seconds of runtime on my machine.
Bytes have no Byte-Order ;)
Runs out of heap space for the 10K keyset on 32 cores (see create_measurements3.sh):
|
Aha...Tried to simulate at 32/64thread machine. Should pass the 10K set now =). |
Have you tried with 10K keys? It shows differences:
|
Thanks for the command. I wasn't aware of the new 10k test set. I hand a bug indeed. Should be finally fixed. The performance on the 10k 1billion set is bad =). 50+ seconds on my machine. Mostly likely because I was lazy in the comparison function and did not vectorize it for larger key. And my horrible hash may produce to many collisions with more keys as well =) Anyway, I don't plan to fix that and stop myself here. Thanks for all the effort. |
Nice! |
Passes the 10K test too. |
Check List:
./mvnw verify
and the project builds successfully./test.sh <username>
shows no differences between expected and actual outputs)calculate_average_<username>.sh
(make sure to match casing of your GH user name) and is executablecalculate_average_baseline.sh
I stop myself now =).
Thanks again for the learning experience. I've summarized my leanings here: https://www.gamlor.info/posts-output/2024-01-12-one-billion-row-challenge/en/