Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melgenek: minor improvements #655

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

melgenek
Copy link
Contributor

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)

These changes cut ~1s out of 6s in a Lima VM with 8 cores.

@gunnarmorling
Copy link
Owner

This runs out of heap space for the 10K key set (see _create_measurements_3.sh) when testing with 32 cores:

Terminating due to java.lang.OutOfMemoryError: Java heap space

@melgenek
Copy link
Contributor Author

Sorry, forgot to make the change to add more memory.

@gunnarmorling I was testing locally only against the 10k dataset. While you're testing 10k anyway, could you please tell me how much time it takes to process 10k on the target machine?

@gunnarmorling
Copy link
Owner

Looking good now. 00:05.167 now. 00:07.137 for the 10K key set.

@gunnarmorling gunnarmorling merged commit c5b7b19 into gunnarmorling:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants