Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just when I thought i was out.... #660

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

iziamos
Copy link
Contributor

@iziamos iziamos commented Jan 30, 2024

Check List:

  • You have run ./mvnw verify and the project builds successfully
  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • [ x Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • [ x For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
  • Execution time: Subsecond on my machine. Maybe 10% faster than previous version with just the vm change
  • Execution time of reference implementation: 1:35.20

Okay so the last thing I hadn't explored was graal native. It shows improvement on my machine which I guess is down to less compiling? Would really like to see how this fares on the proper test rig. Obviously I've added a prepare script etc. Really curious how this does in the 32 core run as well if you do one at the end because I'm emotionally attatched to a "thousands of virtual threads" implementation.

@gunnarmorling
Copy link
Owner

00:03.820 now.

@gunnarmorling gunnarmorling merged commit e2ee4cb into gunnarmorling:main Jan 31, 2024
1 check passed
@gunnarmorling
Copy link
Owner

Hey @iziamos!

Congrats again on being in the Top 20 of the One Billion Row Challenge!

To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it.

All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes!

Thanks a lot for participating in 1BRC,

--Gunnar

@iziamos
Copy link
Contributor Author

iziamos commented Feb 11, 2024

Hey @iziamos!

Congrats again on being in the Top 20 of the One Billion Row Challenge!

To celebrate this amazing achievement, I would like to send you a 1BRC t-shirt and coffee mug. To claim your prize, fill out this form by Feb 18. After submitting the form, please provide a comment with the random value you've specified in the form, so that I know it is you who submitted it.

All data entered will solely be used in relation to processing this shipment. Shipments can be sent to any country listed here or here (I'll use whichever one is cheaper for me to ship to your location). A big thank you to Decodable for sponsoring these prizes!

Thanks a lot for participating in 1BRC,

--Gunnar

How exciting! :D
My random numbers are 13415 22471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants