Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause patch #48

Merged
merged 2 commits into from
Oct 10, 2015
Merged

Pause patch #48

merged 2 commits into from
Oct 10, 2015

Conversation

ewnd9
Copy link
Contributor

@ewnd9 ewnd9 commented Oct 9, 2015

On pause audio stop playing with ~1 sec delay, resume works immediately.
Also please keep in mind like in previous pull request I didn't include rebuilded dists, so you need to do it before publishing new version on npm

@guo-yu
Copy link
Owner

guo-yu commented Oct 10, 2015

Sure, thank you so much

guo-yu added a commit that referenced this pull request Oct 10, 2015
@guo-yu guo-yu merged commit 37b82ed into guo-yu:master Oct 10, 2015
@ewnd9
Copy link
Contributor Author

ewnd9 commented Oct 10, 2015

🎉

@ewnd9 ewnd9 mentioned this pull request Oct 17, 2015
@kingdido999
Copy link

@ewnd9 Hi, I'm experiencing a 1~2 secs delay on pause() and stop() when playing from url with stream enabled. I noticed that both methods are calling:

this.speaker.Speaker.end()

which means it's an issue with node-speaker? Is there any room for speed improvement? Thank you.

@ewnd9
Copy link
Contributor Author

ewnd9 commented Jan 26, 2016

@kingdido999 Yep, I suppose it's related to TooTallNate/node-speaker#13 or TooTallNate/node-speaker#37

@kingdido999
Copy link

@ewnd9 Thanks, I'll look into them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants