Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AWS SDK v2 #206

Closed
wants to merge 13 commits into from
Prev Previous commit
Next Next commit
Remove unnecessary parenthesis
  • Loading branch information
irohirokid committed Nov 8, 2022
commit 4304bbfd0411820620e99f8291741fe7fb428ee2
2 changes: 1 addition & 1 deletion createtable_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func TestCreateTable(t *testing.T) {
}},
Projection: &types.Projection{
ProjectionType: types.ProjectionTypeInclude,
NonKeyAttributes: []string{("UUID")},
NonKeyAttributes: []string{"UUID"},
},
}},
ProvisionedThroughput: &types.ProvisionedThroughput{
Expand Down
2 changes: 1 addition & 1 deletion encode_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ var itemEncodeOnlyTests = []struct {
out: map[string]types.AttributeValue{
"L": &types.AttributeValueMemberL{Value: []types.AttributeValue{}},
"M": &types.AttributeValueMemberM{Value: map[string]types.AttributeValue{}},
"Other": &types.AttributeValueMemberBOOL{Value: (true)},
"Other": &types.AttributeValueMemberBOOL{Value: true},
},
},
{
Expand Down
60 changes: 30 additions & 30 deletions encoding_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,22 +195,22 @@ var encodingTests = []struct {
name: "array with empty string",
in: [...]string{"", "hello", "", "world", ""},
out: &types.AttributeValueMemberL{Value: []types.AttributeValue{
&types.AttributeValueMemberS{Value: ("")},
&types.AttributeValueMemberS{Value: ("hello")},
&types.AttributeValueMemberS{Value: ("")},
&types.AttributeValueMemberS{Value: ("world")},
&types.AttributeValueMemberS{Value: ("")},
&types.AttributeValueMemberS{Value: ""},
&types.AttributeValueMemberS{Value: "hello"},
&types.AttributeValueMemberS{Value: ""},
&types.AttributeValueMemberS{Value: "world"},
&types.AttributeValueMemberS{Value: ""},
}},
},
{
name: "slice of string pointers",
in: []*string{nil, aws.String("hello"), aws.String(""), aws.String("world"), nil},
out: &types.AttributeValueMemberL{Value: []types.AttributeValue{
&types.AttributeValueMemberNULL{Value: true},
&types.AttributeValueMemberS{Value: ("hello")},
&types.AttributeValueMemberS{Value: ("")},
&types.AttributeValueMemberS{Value: ("world")},
&types.AttributeValueMemberNULL{Value: (true)},
&types.AttributeValueMemberS{Value: "hello"},
&types.AttributeValueMemberS{Value: ""},
&types.AttributeValueMemberS{Value: "world"},
&types.AttributeValueMemberNULL{Value: true},
}},
},
{
Expand Down Expand Up @@ -241,7 +241,7 @@ var encodingTests = []struct {
out: &types.AttributeValueMemberL{Value: []types.AttributeValue{
&types.AttributeValueMemberB{Value: []byte{}},
&types.AttributeValueMemberB{Value: []byte{'h', 'e', 'l', 'l', 'o'}},
&types.AttributeValueMemberNULL{Value: (true)},
&types.AttributeValueMemberNULL{Value: true},
&types.AttributeValueMemberB{Value: []byte{'w', 'o', 'r', 'l', 'd'}},
&types.AttributeValueMemberB{Value: []byte{}},
}},
Expand All @@ -261,7 +261,7 @@ var itemEncodingTests = []struct {
A: "hello",
},
out: map[string]types.AttributeValue{
"A": &types.AttributeValueMemberS{Value: ("hello")},
"A": &types.AttributeValueMemberS{Value: "hello"},
},
},
{
Expand All @@ -272,7 +272,7 @@ var itemEncodingTests = []struct {
A: "hello",
},
out: map[string]types.AttributeValue{
"A": &types.AttributeValueMemberS{Value: ("hello")},
"A": &types.AttributeValueMemberS{Value: "hello"},
},
},
{
Expand All @@ -294,7 +294,7 @@ var itemEncodingTests = []struct {
A: "hello",
},
out: map[string]types.AttributeValue{
"renamed": &types.AttributeValueMemberS{Value: ("hello")},
"renamed": &types.AttributeValueMemberS{Value: "hello"},
},
},
{
Expand All @@ -307,7 +307,7 @@ var itemEncodingTests = []struct {
Other: true,
},
out: map[string]types.AttributeValue{
"Other": &types.AttributeValueMemberBOOL{Value: (true)},
"Other": &types.AttributeValueMemberBOOL{Value: true},
},
},
{
Expand All @@ -322,7 +322,7 @@ var itemEncodingTests = []struct {
Other: true,
},
out: map[string]types.AttributeValue{
"Other": &types.AttributeValueMemberBOOL{Value: (true)},
"Other": &types.AttributeValueMemberBOOL{Value: true},
},
},
{
Expand Down Expand Up @@ -586,23 +586,23 @@ var itemEncodingTests = []struct {
NS5: map[uint]bool{maxUint: true},
},
out: map[string]types.AttributeValue{
"SS1": &types.AttributeValueMemberSS{Value: []string{("A"), ("B")}},
"SS2": &types.AttributeValueMemberSS{Value: []string{("true"), ("false")}},
"SS3": &types.AttributeValueMemberSS{Value: []string{("A")}},
"SS4": &types.AttributeValueMemberSS{Value: []string{("A")}},
"SS5": &types.AttributeValueMemberSS{Value: []string{("A")}},
"SS6": &types.AttributeValueMemberSS{Value: []string{("A"), ("B")}},
"SS7": &types.AttributeValueMemberSS{Value: []string{("true")}},
"SS8": &types.AttributeValueMemberSS{Value: []string{("false")}},
"SS9": &types.AttributeValueMemberSS{Value: []string{("A"), ("B"), ("")}},
"SS10": &types.AttributeValueMemberSS{Value: []string{("A")}},
"SS1": &types.AttributeValueMemberSS{Value: []string{"A", "B"}},
"SS2": &types.AttributeValueMemberSS{Value: []string{"true", "false"}},
"SS3": &types.AttributeValueMemberSS{Value: []string{"A"}},
"SS4": &types.AttributeValueMemberSS{Value: []string{"A"}},
"SS5": &types.AttributeValueMemberSS{Value: []string{"A"}},
"SS6": &types.AttributeValueMemberSS{Value: []string{"A", "B"}},
"SS7": &types.AttributeValueMemberSS{Value: []string{"true"}},
"SS8": &types.AttributeValueMemberSS{Value: []string{"false"}},
"SS9": &types.AttributeValueMemberSS{Value: []string{"A", "B", ""}},
"SS10": &types.AttributeValueMemberSS{Value: []string{"A"}},
"BS1": &types.AttributeValueMemberBS{Value: [][]byte{{'A'}, {'B'}}},
"BS2": &types.AttributeValueMemberBS{Value: [][]byte{{'A'}}},
"BS3": &types.AttributeValueMemberBS{Value: [][]byte{{'A'}}},
"BS4": &types.AttributeValueMemberBS{Value: [][]byte{{'A'}, {'B'}, {}}},
"NS1": &types.AttributeValueMemberNS{Value: []string{("1"), ("2")}},
"NS2": &types.AttributeValueMemberNS{Value: []string{("1"), ("2")}},
"NS3": &types.AttributeValueMemberNS{Value: []string{("1"), ("2")}},
"NS1": &types.AttributeValueMemberNS{Value: []string{"1", "2"}},
"NS2": &types.AttributeValueMemberNS{Value: []string{"1", "2"}},
"NS3": &types.AttributeValueMemberNS{Value: []string{"1", "2"}},
"NS4": &types.AttributeValueMemberNS{Value: []string{maxIntStr}},
"NS5": &types.AttributeValueMemberNS{Value: []string{maxUintStr}},
},
Expand Down Expand Up @@ -700,14 +700,14 @@ var itemEncodingTests = []struct {
},
{
name: "dynamodb.ItemUnmarshaler",
in: customItemMarshaler{Thing: (52)},
in: customItemMarshaler{Thing: 52},
out: map[string]types.AttributeValue{
"thing": &types.AttributeValueMemberN{Value: "52"},
},
},
{
name: "*dynamodb.ItemUnmarshaler",
in: &customItemMarshaler{Thing: (52)},
in: &customItemMarshaler{Thing: 52},
out: map[string]types.AttributeValue{
"thing": &types.AttributeValueMemberN{Value: "52"},
},
Expand Down