Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gang count and position to ra3/hwqsx control stations #130

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

danaues
Copy link
Contributor

@danaues danaues commented Oct 27, 2022

Adding 2 fields into the devices dict for RA3/HWQSX keypads/picos:
gang_position (which position the keypad resides in a multi-gang station)
gang_count (how many ganged devices are in the control station)

These fields will allow for better device/entity naming.

Currently each keypad has "Position 1" in it's name, even if it's the only keypad in that location. Even a single pico on a pedestal gets the "Position 1" added to it's name.

With these fields, we can detect if it's in a single gang, and ignore the position name.

ie "Rec Room Coffee Table Position 1 Pico" becomes "Rec Room Coffee Table Pico"

The gang_position field will allow us to convert the position to an ordinal (1st, 2nd etc) without having to parse the number out of the device_name field.

@iCSpotRun
Copy link
Contributor

@danaues I would love to see this PR get merged. Dealing with a setup where many multi-gangs

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants