-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemu-arm-static isn't needed when already on an arm64 box #228
Conversation
It is needed if you want to build from amd64. Unless I missed something then you need this in that case. |
I will have to test this again. I was building an arm64 image on an arm64 system and kept hitting that and the script failed. |
Ok if it fails then I wonder why - I am building on an arm64 arm64 images and it does not fail. |
Yeah I will do more testing. I specifically don’t want to use qemu-arm-static because this is being built in a per-minute VPS builder. Dropping the unneeded emulator cuts the assembly by 2/3 or more. |
Any update on this? |
I am still using the patch and it continues to work and be accurate. I'm building the Pi images on an arm64 Amazon instance where the system type is aarch64/armv8 and not armhf/armv7hf. The use of qemu-arm-static is entirely unnecessary for that. |
I have re-confirmed that this patch is still necessary if you are already on an aarch64 system with the right stuff installed:
In the code:
All of the tests in the code lead to the system still trying to use qemu-arm-static to build an aarch64 system even though it already is an aarch64 system and doesn't need qemu. This is seen later in the code here:
|
Replacing this is a better fix contained in #240 |
When building a Pi image, if you're already on an arm64/aarch64 system, there's no need to try to install/use
qemu-arm-static
binary for the build.