Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounting sys directory to allow building of arm64 images #238

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

sharpn
Copy link

@sharpn sharpn commented Nov 20, 2024

When attempting to update in the base module the update of initramfs-tools fails due to the lack of a sys mount. Added mounts to common.sh to allow the update to continue successfully

@guysoft
Copy link
Owner

guysoft commented Nov 20, 2024

Did you test it?

@sharpn
Copy link
Author

sharpn commented Nov 20, 2024

I have yea, I have a successful build working by updating my docker compose to

services:
  custompios:
    # image: guysoft/custompios:devel
    build:
      context: ../../CustomPiOS/src
      dockerfile: Dockerfile
    pull_policy: always
    container_name: piimage-build
    platform: linux/arm64
    tty: true
    restart: always
    privileged: true
    environment:
      - USER=root
      - BASE_BOARD=raspberrypiarm64
    volumes:
      - ./src:/distro
      - ../../CustomPiOS/src:/CustomPiOS
    devices:
      - /dev/loop-control

and running docker exec -it piimage-build build --download

@guysoft
Copy link
Owner

guysoft commented Nov 21, 2024

Before I merge this I want to test if it might cause issues. Since sysfs gives access to the hosts hardware.
Also it might make certain processes assume wrong things about the build (for example, if the host is an amd64 device and they look up the host architecture, and then build for amd64, or another would be they base the initramfs ob the hosts partition table).

If that is the case we can always add a variable in the base module to enable/disable the mount. Just updating why I am not merging this right away.

Also - you guys are using CustomPiOS at LEGO Group? If so cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants