Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#127 adding cancel button #213

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

#127 adding cancel button #213

wants to merge 8 commits into from

Conversation

CiTRuS93
Copy link
Contributor

No description provided.

guytepper
guytepper requested changes Nov 18, 2020
View reviewed changes
src/components/ProtestForm/ProtestForm.js Outdated
@@ -25,6 +26,7 @@ function ProtestForm({
editMode = null,
isAdmin,
}) {
let history = useHistory();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let history = useHistory();
const history = useHistory();

src/components/ProtestForm/ProtestForm.js Outdated
@@ -84,6 +86,9 @@ function ProtestForm({
nearbyProtests();
}, [coordinatesUpdater]);

const onCancel = () => {
history.goBack();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon, I take back my words about the confirmation message.

Add a confirm dialog that says "המידע שהזנת לא יישמר. לחזור אחורה?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was prepared for that 😃

@guytepper guytepper linked an issue Nov 18, 2020 that may be closed by this pull request
Add cancel button to edit protest page #127
Closed
guytepper
guytepper requested changes Nov 24, 2020
View reviewed changes
Copy link
Owner

@guytepper guytepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - some final adjustments:

  • Change the button color to red (use tomato).
  • Make sure when pressing cancel it goes to the protest page - if the user has just signed in it will return to the sign in page

@CiTRuS93
Copy link
Contributor Author 

* Make sure when pressing cancel it goes to the protest page - if the user has just signed in it will return to the sign in page

Hey there, sorry but I didn't manage to figure out how user can go to the protestForm after signing in.

@guytepper
Copy link
Owner

They should go to the protest page; you can take the protest id from the pathname and use it to get to the protest page

guytepper
guytepper reviewed Dec 10, 2020
View reviewed changes
Copy link
Owner

@guytepper guytepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CiTRuS93, have you seen #213 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guytepper guytepper guytepper requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cancel button to edit protest page
2 participants
@CiTRuS93 @guytepper