Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements #3

Open
wants to merge 9 commits into
base: maven
Choose a base branch
from
Open

improvements #3

wants to merge 9 commits into from

Conversation

FrankHossfeld
Copy link
Member

  • update Maven to be more CI-friendly
  • add Java 8 to GitHub action
  • avoid deploying test modules
  • update gwt to 2.9.0
  • remove commented code

@FrankHossfeld
improvements
c04e43c 
* update Maven to be more CI-friendly
* add Java 8 to GitHub action
* avoid deploying test modules
* update gwt to 2.9.0
* remocve commented code
@FrankHossfeld
update README.md
d79967f
niloc132
niloc132 reviewed Jun 6, 2020
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: when this is merged, be sure "rebase" is clicked so we avoid the merge commit, as thomas requested

Also, should the first commit be cherry-picked instead? I think Thomas wrote something earlier for this?

gwt-event-j2cl-tests/pom.xml Outdated Show resolved Hide resolved
gwt-event-logical-gwt2-tests/pom.xml Outdated Show resolved Hide resolved
gwt-event-compat-gwt2-tests/pom.xml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gwt-event-logical-j2cl-tests/pom.xml Outdated Show resolved Hide resolved
gwt-event-compat-gwt2-tests/pom.xml Outdated Show resolved Hide resolved
gwt-event-gwt2-tests/pom.xml Outdated Show resolved Hide resolved
@FrankHossfeld
Copy link
Member Author

Can you explain, why we should cherry pick, please. I forked this repo and worked based on the latest commit.

@niloc132
Copy link
Member

niloc132 commented Jun 6, 2020

cherry-pick: I screwed up, this doesn't apply - I was thinking of changes started to gwt-http

tbroyer
tbroyer reviewed Jun 7, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/maven.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.mvn/maven.config Outdated Show resolved Hide resolved
gwt-event-compat/pom.xml Outdated Show resolved Hide resolved
gwt-event-compat/pom.xml Outdated Show resolved Hide resolved
gwt-event-compat/pom.xml Outdated Show resolved Hide resolved
gwt-event-compat/pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@FrankHossfeld
Copy link
Member Author

@tbroyer Please, review again.

MCMicS
MCMicS reviewed Jun 10, 2020
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCMicS MCMicS MCMicS left review comments

@niloc132 niloc132 niloc132 left review comments

@tbroyer tbroyer tbroyer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankHossfeld @niloc132 @tbroyer @MCMicS