Skip to content

Commit

Permalink
Set java 11 as minimum for sample apps templates (#10019)
Browse files Browse the repository at this point in the history
Change minimum java source level in the WebAppCreator sample from 1.7,
1.8 to 11
  • Loading branch information
vegegoku authored Oct 31, 2024
1 parent 9af1f1d commit a5e628b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions user/src/com/google/gwt/user/tools/templates/ant/build.xmlsrc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<mkdir dir="@warFolder/WEB-INF/classes"/>
<javac srcdir="@srcFolder" includes="**" encoding="utf-8"
destdir="@warFolder/WEB-INF/classes"
source="1.7" target="1.7" nowarn="true"
source="11" target="11" nowarn="true"
debug="true" debuglevel="lines,vars,source">
<classpath refid="project.class.path"/>
</javac>
Expand Down Expand Up @@ -70,7 +70,7 @@
@testTargetsBegin
<target name="javac.tests" depends="javac" description="Compiles test code">
<javac srcdir="@testFolder" includes="**" encoding="utf-8"
source="1.7" target="1.7" nowarn="true"
source="11" target="11" nowarn="true"
destdir="@warFolder/WEB-INF/classes"
debug="true" debuglevel="lines,vars,source">
<classpath location="@junitJar"/>
Expand Down
11 changes: 5 additions & 6 deletions user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@

<properties>

<!-- Setting maven.compiler.source to something different to 1.8
<!-- Setting maven.compiler.source to something different to 11
needs that you configure the sourceLevel in gwt-maven-plugin since
GWT compiler 2.8 and above requires 1.8 (see gwt-maven-plugin block below) -->
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
GWT compiler 2.12.0 and above requires 11 (see gwt-maven-plugin block below) -->
<maven.compiler.release>11</maven.compiler.release>

<!-- Don't let your Mac use a crazy non-standard encoding -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -83,9 +82,9 @@
<moduleName>@moduleName</moduleName>
<moduleShortName>@moduleShortName</moduleShortName>
<failOnError>true</failOnError>
<!-- GWT compiler 2.8 and above requires 1.8, hence define sourceLevel here if you use
<!-- GWT compiler 2.12.0 and above requires 11, hence define sourceLevel here if you use
a different source language for java compilation -->
<sourceLevel>1.8</sourceLevel>
<sourceLevel>11</sourceLevel>
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
Expand Down

0 comments on commit a5e628b

Please sign in to comment.