Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base image installation moved to separate Dockerfile #558

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

dolsysmith
Copy link
Contributor

@dolsysmith dolsysmith commented Jul 31, 2024

The non-Ruby dependencies have been moved to a separate Docker image, from which the scholarspace-app image (the main Dockerfile) inherits. The base image (scholarspace-base) has been pushed to the GHCR, so when building the app image locally, the hosted base image will be used, which should expedite the CI/CD workflow.

To Test

  • On your dev server, remove the existing scholarspace-app image then rebuild the latter locally, verifying that the image builds as expected.
  • Verify that the app runs as expected.

Post-merge tasks

  • I'll set up a new GitHub Action that will be triggered only upon changes to Dockerfile-base, which will build the image and push the updated image to the GHCR.

@dolsysmith dolsysmith requested a review from alepbloyd July 31, 2024 13:23
@dolsysmith
Copy link
Contributor Author

Note that this PR now also contains a change to the CI-cache workflow file, in order to allow the GitHub Actions runner to log into GHCR and fetch the scholarspace-base image.

I have verified that with that change, the CI worflow runs as expected.

@alepbloyd
Copy link
Contributor

Just tested, all looks good to me!

@dolsysmith dolsysmith merged commit e0cf6ba into master Aug 8, 2024
1 check passed
@dolsysmith dolsysmith deleted the t486-docker-base-image branch August 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants