Support autojump in popup SelectView
#793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, only support autojump when the popup is closed, and not inside the menu popup itself. Note that autojump fires the select callback, while popup mode previously only fired the submit callback.
gyscos
approved these changes
Jun 13, 2024
|
Thanks for the work! |
gyscos
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Fix SelectView clippy warning Fixes: c173bbf ("Support autojump in popup SelectView (#793)") * Support replacing angle brackets in SelectView popup button Allow a SelectView to be configured with custom decorators instead of the angle brackets around the current item label. Fix up calculation of the available width for the item label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only support autojump when the popup is closed, and not inside the menu popup itself.
Note that autojump fires the select callback, while popup mode previously only fired the submit callback.