Fix zstd-sys in thin mode: Replace ZSTD_LIB_MINIFY with actual #defines
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fine`s since `ZSTD_LIB_MINIFY` is only used in `Makefile` to enable other `#define`s. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
commented
Jan 27, 2023
Comment on lines
+168
to
+179
| // We cannot use ZSTD_LIB_MINIFY since it is only | ||
| // used in Makefile to define other options. | ||
|
|
||
| config | ||
| .define("HUF_FORCE_DECOMPRESS_X1", Some("1")) | ||
| .define("HUF_FORCE_DECOMPRESS_X2", Some("0")) | ||
| .define("ZSTD_FORCE_DECOMPRESS_SEQUENCES_SHORT", Some("1")) | ||
| .define("ZSTD_FORCE_DECOMPRESS_SEQUENCES_LONG", Some("0")) | ||
| .define("ZSTD_NO_INLINE", Some("1")) | ||
| // removes the error messages that are | ||
| // otherwise returned by ZSTD_getErrorName | ||
| .define("ZSTD_STRIP_ERROR_STRINGS", Some("1")); |
There was a problem hiding this comment.
These lines works in a similar fashion to https://github.com/facebook/zstd/blob/f302ad8811643c428c4e3498e28f53a0578020d3/lib/libzstd.mk#L32-L37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since
ZSTD_LIB_MINIFYis only used inMakefileto enable other#defines.Fixed bug introduced in #189 and in pointed out by @nickbabcock in #190 (comment)
Signed-off-by: Jiahao XU [email protected]