Improvements and bugfixes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vedina What should we do with this PR? |
|
merge, but later , let me find time to look at it |
vedina
approved these changes
Apr 22, 2024
|
@vedina Since you approved the changes, should I go ahead and merge it now? I already checked that there are no conflicts with nexusformat. |
|
yes, pls merge |
- These modifications make it easier to create a spectrum with multiple Raman bands with different shape types and parameters. - Provide a default value for the pedestal (baseline) of add_baseline as it is usually not used
rng_seed is updated inplace. This requires processing data to be deeply copied before execution.
kerberizer
force-pushed
the
improvements_bugfixes
branch
from
b62458e to
51b6a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.