GH-6605 Fix feature interaction for CV model where tree has depth = 0 #15699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurever
changed the title
valenad1
reviewed
Aug 16, 2023
| @@ -43,6 +43,9 @@ public void mergeWith(FeatureInteractions featureInteractions) { | |||
| } | |||
|
|
|||
| public int maxDepth() { | |||
| if (this.entrySet().size() == 0){ | |||
| return 0; | |||
There was a problem hiding this comment.
It's weird that actual problem is that FeatureInteractions are empty and all call has no meaning and we handle it in maxDepth funtion. It would be better to check that earlier and raise warning to the user.
There was a problem hiding this comment.
It can be simulated this way also:
FeatureInteractions featureInteractions1 = new FeatureInteractions();
System.out.println("featureInteractions1 = " + Arrays.toString(featureInteractions1.getAsTable()));
in FeatureInteractionsTest
There was a problem hiding this comment.
Thanks, @valenad1. Good points! I fixed the case there is no feature interaction for a model.
valenad1
reviewed
Aug 17, 2023
| # feature interaction with cv model where tree depth = 0 | ||
| my_cv_gbm <- h2o.getModel(my_gbm@model$cross_validation_models[[1]]$name) | ||
| fi <-h2o.feature_interaction(model = my_cv_gbm) | ||
| #print(fi == NaN) |
There was a problem hiding this comment.
I would turn it to assert
expect_true(is.null(fi))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part was fixed here: #15689.
But I found another bug: when the CV model tree has depth 0, it failed. So this PR fixed this bug.
Closes: #6605