Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement 'tooltip' for markdown cell overflow #1736

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

monal20
Copy link
Contributor

@monal20 monal20 commented Dec 6, 2022

Added tooltip functionality for when cell type ui.markdown_table_cell_type overflows.

Below is an example of a Table containing markdown content with both wrap and tooltip functionality:

markdown_overflow.mov

Closes #1645

@monal20 monal20 marked this pull request as draft December 6, 2022 02:44
@monal20 monal20 marked this pull request as ready for review December 6, 2022 03:12
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @monal! A few small comments.

py/examples/table_markdown_overflow.py Show resolved Hide resolved
@monal20
Copy link
Contributor Author

monal20 commented Dec 6, 2022

Thanks @mturoci for the review. I have implemented the changes you requested.

Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @monal20!

@mturoci mturoci merged commit 85a124a into h2oai:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow cell overflow "tooltip" for cell type "markdown"
2 participants