Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSP] enhancements to example policy #181

Merged
merged 9 commits into from
Mar 26, 2019
Merged

[CSP] enhancements to example policy #181

merged 9 commits into from
Mar 26, 2019

Conversation

Malvoz
Copy link
Contributor

@Malvoz Malvoz commented Mar 18, 2019

Fix #156

Also, with these changes the CSP frame-ancestors directive description now mentions the relation to X-Frame-Options (https://w3c.github.io/webappsec-csp/#frame-ancestors-and-frame-options). Seems logical X-Frame-Options should say something about frame-ancestors/CSP? I can probably do that tomorrow, really tired atm. :)

Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, impressive PR, thanks a lot @Malvoz! 👍
As you may expect, some comments (inline). 😉

src/security/content-security-policy.conf Outdated Show resolved Hide resolved
src/security/content-security-policy.conf Outdated Show resolved Hide resolved
src/security/content-security-policy.conf Show resolved Hide resolved
src/security/content-security-policy.conf Outdated Show resolved Hide resolved
src/security/content-security-policy.conf Outdated Show resolved Hide resolved
@Malvoz
Copy link
Contributor Author

Malvoz commented Mar 18, 2019

form-action is a navigation directive, only fetch directives falls back to default-src.

Do you want me to clarify that, here(?):

# (3) Form submissions are only allowed from the current website by
# setting: `form-action 'self'`.

Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM.

May be relevant to add reflected-xss block too, but not mandatory.

@LeoColomb LeoColomb requested a review from XhmikosR March 26, 2019 11:26
@LeoColomb LeoColomb merged commit f48934b into h5bp:master Mar 26, 2019
LeoColomb added a commit to h5bp/server-configs-nginx that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants