Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added search indexing class for indexing basic activity information (… #286

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

iceripple
Copy link

indexes common module data (name and intro)
see https://docs.moodle.org/dev/Search_API#Easy_case:_Activity_information

(cherry picked from commit 6819a46)

@iceripple
Copy link
Author

new pull request in response to #275

@thomasmars
Copy link
Member

Thanks for the pull request. I've created an issue for reviewing and merging it in through our public issue tracker: https://h5ptechnology.atlassian.net/browse/HFP-2811.
I'll try to get it included on the next Moodle release if it passes review.

* release: (39 commits)
  Add untranslated error messages from core
  Update library submodule
  Prepare for release 1.19.1
  Update editor submodule containing translations fixes
  Fix bug that was crashing clearFilteredParameters with empty libraryids
  Remove ci setup that is not currently working
  Fix php codechecker complaint
  Fix code style complaints
  Prepare for release 1.19
  Fix moveContentDirectory not returning content json files any more
  Fix saveFileFromZip and new implementation of clear filtered params
  Update submodules
  Update README.md
  Update README.md
  Fix issue with Totara 13 XSS hardening
  Update README.md
  Update french translations
  Implement support for new AJAX end-point
  Update editor
  Update editor
  ...
@thomasmars
Copy link
Member

getting the following error when running cron with these changes:

++ Invalid get_string() identifier: 'search:activity' or component 'mod_hvp'. Perhaps you are missing $string['search:activity'] = ''; in mod/hvp/lang/en/hvp.php? ++
* line 353 of /lib/classes/string_manager_standard.php: call to debugging()
* line 7289 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
* line 146 of /search/classes/base.php: call to get_string()
* line 1104 of /search/classes/manager.php: call to core_search\base->get_visible_name()
* line 59 of /lib/classes/task/search_index_task.php: call to core_search\manager->index()
* line 189 of /lib/cronlib.php: call to core\task\search_index_task->execute()
* line 114 of /lib/cronlib.php: call to cron_run_inner_scheduled_task()
* line 73 of /lib/cronlib.php: call to cron_run_scheduled_tasks()
* line 81 of /admin/cron.php: call to cron_run()
Processing area: [[search:activity]]

This must be fixed before this can be merged in

iceripple added 2 commits June 4, 2020 16:44
# Conflicts:
#	editor
#	library
#	version.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants