Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates API endpoints for Events #29

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Conversation

SilveerDusk
Copy link
Collaborator

@SilveerDusk SilveerDusk commented Jan 27, 2024

Developer: Jason Jelincic

Closes #14 and #15

Pull Request Summary

Creates all API endpoints for events (GET, POST, PATCH, DELETE)

Modifications

api/events :
Get request for all events
Post request to post a event
api/events/[eventId] :
Get request for a single event
Delete request to delete an event
Patch request to update an event

Testing Considerations

Need help gaining access to Atlas so I can do proper testing.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screenshot 2024-02-04 at 2 04 43 AM
Screenshot 2024-02-04 at 2 05 11 AM
Screenshot 2024-02-04 at 9 05 36 PM
Screenshot 2024-02-04 at 9 05 55 PM
Screenshot 2024-02-04 at 9 06 10 PM
Screenshot 2024-02-04 at 9 06 22 PM
Screenshot 2024-02-04 at 9 06 32 PM
Screenshot 2024-02-04 at 9 06 43 PM

@SilveerDusk SilveerDusk linked an issue Jan 27, 2024 that may be closed by this pull request
@SilveerDusk SilveerDusk marked this pull request as draft January 27, 2024 22:50
@SilveerDusk SilveerDusk added this to the Milestone 1 milestone Jan 27, 2024
@SilveerDusk SilveerDusk linked an issue Jan 27, 2024 that may be closed by this pull request
@SilveerDusk SilveerDusk marked this pull request as ready for review January 27, 2024 23:34
@javalosr2004 javalosr2004 self-requested a review January 28, 2024 01:08
Copy link
Collaborator

@javalosr2004 javalosr2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if you could test out the API endpoints for GET and whenever you finish the admin endpoints for those as well. If you need access to mongodb, lmk, but a good way of testing if your route is working could be to first POST and then use GET, that way you don't need to first put sample data.

@SilveerDusk SilveerDusk marked this pull request as draft February 4, 2024 10:05
@SilveerDusk
Copy link
Collaborator Author

@javalosr2004 Can I get access to mongodb? I finished the rest of the api calls so they just need to be tested in the morning.

@SilveerDusk SilveerDusk changed the title Creates Get endpoints to get all events or an individual event Creates API endpoints for Events Feb 5, 2024
@SilveerDusk SilveerDusk marked this pull request as ready for review February 5, 2024 05:03
@SilveerDusk
Copy link
Collaborator Author

All API have now been tested on postman!

@SilveerDusk
Copy link
Collaborator Author

The merge conflicts are just from me installing chakra to make the UI work in my branch, so you can just keep the main version as my changes to the json files have nothing to do with the issues this pr resolves.

Copy link
Collaborator

@javalosr2004 javalosr2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks amazing, nice error checking and making sure that only properties that are available are used in the PATCH endpoint.

@javalosr2004 javalosr2004 merged commit 0478cd4 into main Feb 5, 2024
1 of 4 checks passed
@javalosr2004 javalosr2004 deleted the Creating-admin-event-endpoints branch February 5, 2024 05:16
javalosr2004 added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Event Endpoints GET Event Endpoint
2 participants