Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation component #37

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Confirmation component #37

merged 3 commits into from
Feb 4, 2024

Conversation

logancostello
Copy link
Collaborator

Developer: Logan Costello

Closes #{ISSUE NUMBER HERE}

Pull Request Summary

Created confirmation component.
Component has 4 fields:
1. buttonName: name of button that prompts warning and confirms action (Create, Edit, Delete, etc)
2. title: title of warning message (Delete User?, Create Event?, etc)
3. message: warning message (Are you sure you want to delete this event? This action is not reversible.)
4. isPositive: changes color of confirmation to indicate type of action (True: Create, edit, etc. False: Delete, remove, etc)

Modifications

Created: Confirmation.tsx (The new component)
Changed: Button.tsx (Jesus' change on my computer)

Testing Considerations

Tested various inputs for the props.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screen Shot 2024-02-03 at 2 06 36 PM Screen Shot 2024-02-03 at 2 05 49 PM Screen Shot 2024-02-03 at 2 01 52 PM

@logancostello logancostello linked an issue Feb 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@javalosr2004 javalosr2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@javalosr2004 javalosr2004 merged commit 59e3ef3 into main Feb 4, 2024
1 of 4 checks passed
@javalosr2004 javalosr2004 deleted the confirmation-component branch February 4, 2024 00:46
javalosr2004 added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation Component
2 participants