Filter project by completion status #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinehuang
reviewed
Mar 13, 2021
backend/tests/test_project.py
Outdated
| @@ -173,7 +173,107 @@ def test_get_specific_type(self): | |||
| json_response = json.loads(response3.get_data(as_text=True)) | |||
| self.assertEqual(len(json_response), 2) | |||
|
|
|||
| # test get endpoint by completion status | |||
| def test_get_projects_by_completion_status(self): | |||
| test_list = [True, False] | |||
There was a problem hiding this comment.
is there a reason why you decided to make a boolean array?
There was a problem hiding this comment.
Not really, thought it would be easier to see the tested inputs when it comes to code review.
There was a problem hiding this comment.
Ok, this is more of a nitpick & stylistic preference but I think it would be more readable if you just used the Boolean values instead and I think it's more commonly done that way anyways so the code reader knows exactly what to expect
There was a problem hiding this comment.
Thanks for the suggestion Celine, and also apologies for the confusion. I have updated the boolean values accordingly
celinehuang
approved these changes
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filtering projects by the [True, False] completion status
Test Plan
Passed all unit tests
Which issues does this PR resolve/work on?
Working On #131