Display all projects in landing page #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm not sure why since the img is in a web url but I'm having trouble displaying the images |
|
the layout looks solid but maybe add the backend call in this PR as well? |
peterghrong
force-pushed
the
peter/display-projects
branch
2 times, most recently
from
0b51ac2 to
f105f7a
Compare
It is actually included thanks to @CurtisMIT , go to the backend folder, run |
CurtisMIT
reviewed
Jun 27, 2021
There was a problem hiding this comment.
@peterghrong overall looks good to me. A minor question, why inprogress over inProgress?
CurtisMIT
reviewed
Jun 27, 2021
| }: ProjectCardProps) => { | ||
| return ( | ||
| <div> | ||
| <img src="https://assets.bonappetit.com/photos/5c62e4a3e81bbf522a9579ce/5:4/w_2815,h_2252,c_limit/milk-bread.jpg"></img> |
There was a problem hiding this comment.
@peterghrong sorry is it possible to add a dummy alt property here to suppress the compiler warnings lol
peterghrong
force-pushed
the
peter/display-projects
branch
from
f105f7a to
4045590
Compare
peterghrong
force-pushed
the
peter/display-projects
branch
from
4045590 to
6b72d00
Compare
CurtisMIT
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display all projects in the landing home page, no responsiveness atm so thats a todo.
Test Plan
Who needs testing in the frontend xD
Related Issues
Which issues does this PR resolve/work on?
Closes #131
Lots of bread, cleaned up a bit now its less ugly