Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Auth.js to MUI #1848

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

hollydo
Copy link
Contributor

@hollydo hollydo commented Jan 28, 2025

Fixes #1626

What changes did you make and why did you make them ?

  • Edited Auth.js file to use MUI components

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

auth js before with error
auth js before

Visuals after changes are applied

auth js using mui with error
auth js using mui

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b hollydo-authToMui development
git pull https://github.com/hollydo/VRMS.git authToMui

Copy link
Member

@sasszz sasszz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to enter my email address, receive a login link to my email, and successfully login. Error handling also still works, and submitting an invalid email displays error and makes submit button gray/inactive. Approving!

Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dannyprikaz dannyprikaz merged commit 38cf12a into hackforla:development Feb 6, 2025
2 of 5 checks passed
@JackHaeg
Copy link
Member

JackHaeg commented Feb 6, 2025

@trillium Please take a look at this before Monday's call :)

@JackHaeg
Copy link
Member

@trillium Please take a look at this PR and merge from Danny to double check any issues with review/merge, and provide any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/auth/Auth.js
4 participants