-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Slack image icon with svg icon in communities of practice page #5896
Refactor Slack image icon with svg icon in communities of practice page #5896
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job @aadilahmed. The PR has well-formed branches, descriptive text and screenshots. The code is correct and clean and it looks great in the browser. Thank you!
Review ETA: EOD of 11/16/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm the following:
- Correct branch and linked issue
- Correct code to display the slack icon
- Changes render in different view modes
- Screenshots display the changes correctly
Outstanding job @aadilahmed! Thanks for contributing!
Fixes #5829
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied