Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Slack image icon with svg icon in communities of practice page #5896

Conversation

aadilahmed
Copy link
Member

Fixes #5829

What changes did you make?

  • Replaced img tag for the "Join Slack Channel" button icon with a liquid image element referencing _includes/svg/icon-slack.svg
  • Modified CSS to maintain current appearance of page

Why did you make the changes (we will use this info to test)?

  • To make sure that only a single slack icon svg is used in the codebase
  • Make it easier to render the svg in various colors throughout the website

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied communities-of-practice-before
Visuals after changes are applied communities-of-practice-after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aadilahmed-refactor-communities-of-practice-page-5829 gh-pages
git pull https://github.com/aadilahmed/website.git refactor-communities-of-practice-page-5829

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aadilahmed/website/blob/refactor-communities-of-practice-page-5829/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice Feature: Refactor HTML size: 1pt Can be done in 4-6 hours labels Nov 13, 2023
@roslynwythe roslynwythe self-requested a review November 14, 2023 18:49
pages/communities-of-practice.html Outdated Show resolved Hide resolved
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @aadilahmed. The PR has well-formed branches, descriptive text and screenshots. The code is correct and clean and it looks great in the browser. Thank you!

@agutiernc
Copy link
Member

Review ETA: EOD of 11/16/23
Availability: After 6pm

Copy link
Member

@agutiernc agutiernc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the following:

  • Correct branch and linked issue
  • Correct code to display the slack icon
  • Changes render in different view modes
  • Screenshots display the changes correctly

Outstanding job @aadilahmed! Thanks for contributing!

@t-will-gillis t-will-gillis merged commit b65c995 into hackforla:gh-pages Nov 19, 2023
@aadilahmed aadilahmed deleted the refactor-communities-of-practice-page-5829 branch January 6, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor communities of practice page to replace slack-join-meeting-channel.svg with icon-slack.svg
4 participants