-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: 311 Data (Update Tools, Add Holly Worthen & Bethlehem Berhane) #5855 (complete) #5911
Update Project Profile: 311 Data (Update Tools, Add Holly Worthen & Bethlehem Berhane) #5855 (complete) #5911
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dustinowen!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site. PM's and tools were added.
- Relevant images were included to show visual changes
- The PR request clearly states what was updated
I have one non-functional request. For the why the changes were made section, we generally write reasoning behind the changes. This reasoning can generally be found in the issue's Overview Section
. For this issue it looks like We need to keep project information up to date so that visitors to the website can find accurate information
. Other than that the request looks great! Thanks for taking the time to contribute to the website!
@LRenDO Thank you for pointing that out, I have updated the section stating why changes were made to "We need to keep project information up to date so that visitors to the website can find accurate information." |
Thanks @dustinowen! Looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branches are set up correctly. The requested information was added to the 311 project page and your PR is descriptive and includes screenshots of the changes made. Great work!
Fixes #5855
What changes did you make?
-Update TOOLS
-Update LEADERSHIP
Why did you make the changes (we will use this info to test)?
-We need to keep project information up to date so that visitors to the website can find accurate information.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Project Page:
![5855_before_tools_added](https://private-user-images.githubusercontent.com/137654369/283318882-f21b0cd2-5d0e-4111-9e5c-db89f6c0bfbb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE4ODgyLWYyMWIwY2QyLTVkMGUtNDExMS05ZTVjLWRiODlmNmMwYmZiYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MWY2YzJkNzYxMDJkNTNlMjE5ZDBjNGMzMDJkYjM5YWQyNDI0ODY5NjZmYWFhZWY0YWQ2MzcwY2EyOTU0NWY3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OSq5FP45xYqsKI77shKbVXZvPOufvOsYjXxjkjAL07k)
Project Card
![5855_before_project_card](https://private-user-images.githubusercontent.com/137654369/283319027-6dee1555-fc95-42f5-b0bc-691d1406c22e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE5MDI3LTZkZWUxNTU1LWZjOTUtNDJmNS1iMGJjLTY5MWQxNDA2YzIyZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03Nzc3OGUwNWVmYjJhMjc3MDI0OGVkMjg5OTBlYzg4NzMwNDBlZDJlMTFiY2NmN2U1MWI3MDk4OTljOTIxZDJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CULGeMxlqifmspfwqU-mes3Ea43psgDFwUb9oXt9gm4)
Leadership:
![5855_leadership_before](https://private-user-images.githubusercontent.com/137654369/283319131-1432755d-4714-4d89-bfab-5966f365fa44.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE5MTMxLTE0MzI3NTVkLTQ3MTQtNGQ4OS1iZmFiLTU5NjZmMzY1ZmE0NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MDk2OTFkZTFjZmNiMjBjM2M1NzVkMmYzYWI4MGU1ZTkxMjcwOWEwMDNhMmU3ODU4MTBiZTQzMDY4MTEyNjI3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bTw2XzzBCigqz1-m330aGTYE5Y34pzrp65UdUOZgQ1E)
Visuals after changes are applied
Project Page:
![5855_ after_tools_added](https://private-user-images.githubusercontent.com/137654369/283319315-32c3e3a6-447a-4f3f-ac54-f40d01fc89de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE5MzE1LTMyYzNlM2E2LTQ0N2EtNGYzZi1hYzU0LWY0MGQwMWZjODlkZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YTk5NzZkYTY4MDYwOWYxNmM4YjcxOTcyOTE3MTZmM2JkYTM5YjFmZjcxYmRlMWZhZGZhY2NlMDBiY2FiMDRhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.nHLuRyzwIH07VycHo7Qpgw4eURB4Nhd8z8QE8z85aK4)
Project Card
![5855_after_project_card](https://private-user-images.githubusercontent.com/137654369/283319429-d67c4f10-7616-4593-afcc-c7cf523a288d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE5NDI5LWQ2N2M0ZjEwLTc2MTYtNDU5My1hZmNjLWM3Y2Y1MjNhMjg4ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMmJiZTE3OGEzZjU0YWE5YzE5NmMxZWIwMzk4NTc2MjcyMDgwOTY1ZGM0MWRhZjZkYTI1YWFhNDg3ZGY3YjM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.HIFnWkR8FLSm-CDR8Ahp5fv4KXmvelV_g7Zr65SEuv8)
Leadership:
![5855_leadership_after](https://private-user-images.githubusercontent.com/137654369/283319470-5a89a3b1-4c3f-425e-a937-97bef979fd93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg3ODI4NTIsIm5iZiI6MTczODc4MjU1MiwicGF0aCI6Ii8xMzc2NTQzNjkvMjgzMzE5NDcwLTVhODlhM2IxLTRjM2YtNDI1ZS1hOTM3LTk3YmVmOTc5ZmQ5My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNVQxOTA5MTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZGM4YjIyYTE3MTk4ZTNlYzI4ZmM4M2FiZWUxZjkzNDk1YjMyMzBkNmM3MzU0YjE1OGY0MzA3YThiMTliM2E3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.zk6Mw45dscDyPi-ehlucGaPd2GDwERq2_iW7K7Pi18c)