Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: 311 Data (Update Tools, Add Holly Worthen & Bethlehem Berhane) #5855 (complete) #5911

Merged

Conversation

dustinowen
Copy link
Member

@dustinowen dustinowen commented Nov 16, 2023

Fixes #5855

What changes did you make?

-Update TOOLS
-Update LEADERSHIP

Why did you make the changes (we will use this info to test)?

-We need to keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Project Page:
5855_before_tools_added

Project Card
5855_before_project_card

Leadership:
5855_leadership_before

Visuals after changes are applied

Project Page:
5855_ after_tools_added

Project Card
5855_after_project_card

Leadership:
5855_leadership_after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dustinowen-update-project-profile-311-data-5855 gh-pages
git pull https://github.com/dustinowen/HackLAwebsite.git update-project-profile-311-data-5855

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/dustinowen/website/blob/update-project-profile-311-data-5855/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 16, 2023
@LRenDO LRenDO self-requested a review November 16, 2023 06:19
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dustinowen!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site. PM's and tools were added.
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated

I have one non-functional request. For the why the changes were made section, we generally write reasoning behind the changes. This reasoning can generally be found in the issue's Overview Section. For this issue it looks like We need to keep project information up to date so that visitors to the website can find accurate information. Other than that the request looks great! Thanks for taking the time to contribute to the website!

@dustinowen
Copy link
Member Author

@LRenDO Thank you for pointing that out, I have updated the section stating why changes were made to "We need to keep project information up to date so that visitors to the website can find accurate information."

@LRenDO
Copy link
Member

LRenDO commented Nov 16, 2023

Thanks @dustinowen! Looks great!

@kwangric kwangric self-requested a review November 17, 2023 21:53
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The requested information was added to the 311 project page and your PR is descriptive and includes screenshots of the changes made. Great work!

@kwangric kwangric merged commit b9fb782 into hackforla:gh-pages Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data (Update Tools, Add Holly Worthen & Bethlehem Berhane)
3 participants