Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and additions to Project Profile Card template #5918

Merged

Conversation

roychan1
Copy link
Member

Fixes #5857

What changes did you make?

  • all changes are made within the file "project-profile-card-review-and-update.yml"
  • changed wording in "To track project profile card updates" description and "Update the Technologies?" label
  • added option for new project in "Project Name" and "Project Card URL" drop downs
  • added drop down for Hero Image Update
  • cleaned up line spacings
  • changed "Update the image?" type from input to textarea

Why did you make the changes (we will use this info to test)?

  • need to accommodate for new projects and hero image update
  • style and wording changes are to make the format uniform

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes on website, the modified file is an Issue Form Template.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b roychan1-edit-project-profile-card-5857 gh-pages
git pull https://github.com/roychan1/hackforla-website.git edit-project-profile-card-5857

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/roychan1/website/blob/edit-project-profile-card-5857/CONTRIBUTING.md  

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Nov 17, 2023
@freaky4wrld freaky4wrld self-requested a review November 17, 2023 10:38
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 11/17

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @roychan1 , great work there..... the to/from branch is correct, the changes made and the reason to change are apt and correct, the linked issue is mentioned correctly. The file has uniform format throughout, the change and addition is correctly done as well ....... Approved!!!

@Chrisklangley
Copy link
Contributor

Availability: M-F 6-9pm
ETA: EOD 11/122

Copy link
Contributor

@Chrisklangley Chrisklangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @roychan1

NIce work on on your pull request!
• you correctly linked your issue and your documentation of the changes you made are very clear
•you made all the correct updates to the project-profile-card-review-and-update.yml file

Visually everything looks great!
keep up the good work

@kwangric kwangric merged commit 1170129 into hackforla:gh-pages Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edits and additions to "Project Profile Card" template
4 participants