Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Expunge Assist (Add Mireya V. Aviles) #5927

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

jphamtv
Copy link
Member

@jphamtv jphamtv commented Nov 21, 2023

Fixes #5919

What changes did you make?

  • Added Mireya V. Aviles' information to the leadership variable in the _projects/expunge-assist.md file.

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-11-20 at 21 53 24
Visuals after changes are applied Screenshot 2023-11-20 at 21 57 33

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jphamtv-update-expunge-assist-5919 gh-pages
git pull https://github.com/jphamtv/website.git update-expunge-assist-5919

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jphamtv/website/blob/update-expunge-assist-5919/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 21, 2023
@JanineSooThow JanineSooThow self-requested a review November 21, 2023 08:04
@JanineSooThow
Copy link
Member

Availability: Tuesday 21st November - Wednesdsay 22nd November NZ Time
ETA: Wednesday 22nd November

@JanineSooThow
Copy link
Member

Hello @jphamtv thank you for taking up this issue.

  • The PR matches the correct branch
  • Mireya V. Aviles' information has been correctly added in the _projects/expunge-assist.md file. Code appears clean
  • Changes with Mireya V. Aviles' information have successfully shown up on the H4LA website
  • Links work well
    Well done! It all looks good to me! I will approve this PR.

@freaky4wrld freaky4wrld self-requested a review November 21, 2023 22:21
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 22nd November

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @jphamtv the changes required are done rightly, the to/from branch looks good, the linked issue is also correctly mentioned. The added profile is also visually added in the local environment.
Great work there.......

@kwangric kwangric merged commit 1fb7c6b into hackforla:gh-pages Nov 22, 2023
10 checks passed
@jphamtv jphamtv deleted the update-expunge-assist-5919 branch November 23, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist (Add Mireya V. Aviles)
4 participants