-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Profile HFLA Website Eleftherios Christou #7840
base: gh-pages
Are you sure you want to change the base?
Add Profile HFLA Website Eleftherios Christou #7840
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oiseeurmt Thank you for working on this Good First Issue
!
What you did well:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/website.md
was edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
What needs fixed:
- Please remove the text at the top of the issue so that the line:
Fixes #7752
is the first line of text. - In the body of the issue, under the
CodeQL Alerts
headline, please check off the appropriate checkbox.- If you DID NOT have any CodeQL errors, please check the
I have checked this PR for CodeQL alerts and none were found.
checkbox. - If you DID have CodeQL errors, please check the
I found CodeQL alert(s), and (select one):
checkbox AND the appropriate checkbox for your situation below that.
- If you DID NOT have any CodeQL errors, please check the
Once these are addressed, please feel free to re-request a review from me.
Thanks!
I corrected the PR and re-requested! |
@gmgonzal , please provide your |
Review ETA: EOD 1/26/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oiseeurmt, thank you for taking on this issue!
Things that went well:
- Pull request is done with the correct branch
- Linked issue is in the correct format
- Applicable before and after screenshots are present and load properly
- Changes in the browser are applicable to the issue and clean
- Links and components on the page still work as intended after the changes
Suggested Changes:
- For the "What changes did you make?" section, try to specify where the changes were made like this (you can copy from the original issue): Add new profile after Bonnie and any “Product Owner” entries but before “Developer Co-leads” entries in the projects website markdown file
_projects/website.md
- Make sure to check boxes for completed action items in your linked issue
After making these changes, you can re-request a review from me. Thank you for your hard work!
Review ETA: EOD 1/27/25 |
I made the corrections and re-requested! |
Fixes #7752
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied