Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Profile HFLA Website Eleftherios Christou #7840

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

oiseeurmt
Copy link
Member

@oiseeurmt oiseeurmt commented Jan 21, 2025

Fixes #7752

What changes did you make?

  • Added new profile after Bonnie and any “Product Owner” entries but before “Developer Co-leads” entries in the projects website markdown file _projects/website.md

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b oiseeurmt-website-add-eleftherios-christou-7752 gh-pages
git pull https://github.com/oiseeurmt/website.git website-add-eleftherios-christou-7752

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 21, 2025
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oiseeurmt Thank you for working on this Good First Issue!

What you did well:

What needs fixed:

  • Please remove the text at the top of the issue so that the line: Fixes #7752 is the first line of text.
  • In the body of the issue, under the CodeQL Alerts headline, please check off the appropriate checkbox.
    • If you DID NOT have any CodeQL errors, please check the I have checked this PR for CodeQL alerts and none were found. checkbox.
    • If you DID have CodeQL errors, please check the I found CodeQL alert(s), and (select one): checkbox AND the appropriate checkbox for your situation below that.

Once these are addressed, please feel free to re-request a review from me.
Thanks!

@daras-cu daras-cu requested a review from gmgonzal January 22, 2025 03:19
@oiseeurmt oiseeurmt requested a review from DrAcula27 January 25, 2025 00:06
@oiseeurmt
Copy link
Member Author

@oiseeurmt Thank you for working on this Good First Issue!

What you did well:

* PR is made from the correct branch

* PR links to the correct issue:
  
  * [Update Project Profile: Website Add Eleftherios Christou #7752](https://github.com/hackforla/website/issues/7752)

* The correct file `_projects/website.md` was edited

* No extra edits were made

* Appearance of the website looks good (Chrome and Firefox)

What needs fixed:

* Please remove the text at the top of the issue so that the line: `Fixes #7752` is the first line of text.

* In the body of the issue, under the `CodeQL Alerts` headline, please check off the appropriate checkbox.
  
  * If you DID NOT have any CodeQL errors, please check the `I have checked this PR for CodeQL alerts and none were found.` checkbox.
  * If you DID have CodeQL errors, please check the `I found CodeQL alert(s), and (select one):` checkbox AND the appropriate checkbox for your situation below that.

Once these are addressed, please feel free to re-request a review from me. Thanks!

I corrected the PR and re-requested!

@siyunfeng
Copy link
Member

@gmgonzal , please provide your Review ETA and Availability in the comment when assigned to this PR.

@katiejnete
Copy link
Member

Review ETA: EOD 1/26/25
Availability: 1/26/25

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oiseeurmt, thank you for taking on this issue!

Things that went well:

  • Pull request is done with the correct branch
  • Linked issue is in the correct format
  • Applicable before and after screenshots are present and load properly
  • Changes in the browser are applicable to the issue and clean
  • Links and components on the page still work as intended after the changes

Suggested Changes:

  • For the "What changes did you make?" section, try to specify where the changes were made like this (you can copy from the original issue): Add new profile after Bonnie and any “Product Owner” entries but before “Developer Co-leads” entries in the projects website markdown file _projects/website.md
  • Make sure to check boxes for completed action items in your linked issue

After making these changes, you can re-request a review from me. Thank you for your hard work!

@gmgonzal
Copy link
Member

Review ETA: EOD 1/27/25
Availability: 1/27/25

@oiseeurmt oiseeurmt requested a review from katiejnete January 28, 2025 15:40
@oiseeurmt
Copy link
Member Author

Hi @oiseeurmt, thank you for taking on this issue!

Things that went well:

* Pull request is done with the correct branch

* Linked issue is in the correct format

* Applicable before and after screenshots are present and load properly

* Changes in the browser are applicable to the issue and clean

* Links and components on the page still work as intended after the changes

Suggested Changes:

* [x]  For the "What changes did you make?" section, try to specify where the changes were made like this (you can copy from the original issue): Add new profile after Bonnie and any “Product Owner” entries but before “Developer Co-leads” entries in the projects website markdown file `_projects/website.md`

* [x]  Make sure to check boxes for completed action items in your linked issue

After making these changes, you can re-request a review from me. Thank you for your hard work!

I made the corrections and re-requested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs being reviewed
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Add Eleftherios Christou
5 participants