Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privacy manifest collected data type record updated #2013

Merged

Conversation

muzahid59
Copy link

Description

IQKeyboardManager privacy data missing in the application privacy report.

Reference

Fixes #2012

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@muzahid59 muzahid59 changed the title fix: privacy collected data type record updated fix: privacy manifest collected data type record updated Jan 23, 2024
@hackiftekhar hackiftekhar merged commit 25e1c15 into hackiftekhar:master Jan 27, 2024
@ag-drivequant
Copy link

ag-drivequant commented Feb 20, 2024

@muzahid59 @hackiftekhar

My understanding is that appearing in the privacy report is not a condition.

I expect a privacy manifest file similar to

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>
	<key>NSPrivacyAccessedAPITypes</key>
	<array/>
	<key>NSPrivacyCollectedDataTypes</key>
	<array/>
</dict>
</plist>

The problem that I see with the modification (of this pull request) is that you say there is a collected data type (by adding an item to NSPrivacyCollectedDataTypes array) and you don't specify the type and purpose of collected data (you keep NSPrivacyCollectedDataType and NSPrivacyCollectedDataTypePurposes empty)

Since IQKeyboardManager is not collecting data, I think it's not a problem that you don't see it in the Privacy Report.

@closure11
Copy link
Contributor

I agree with @ag-drivequant . An empty data type item doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IQKeyboardManager privacy data not found in privacy report
5 participants