Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codimd): update codimd from 2.3.2 to 2.4.2 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hairmare
Copy link

@hairmare hairmare commented Aug 8, 2022

In addition to bumping the value in Chart.yaml i'm also removing it from values.yaml so the helper that defaults to using appVersion can do it's thing.

{{- define "codimd.image" -}}
{{- $registryName := default "nabo.codimd.dev" .Values.image.registry -}}
{{- $repositoryName := default "hackmdio/hackmd" .Values.image.repository -}}
{{- $tag := default .Chart.AppVersion .Values.image.tag -}}
{{- printf "%s/%s:%s" $registryName $repositoryName $tag -}}
{{- end -}}

@hairmare
Copy link
Author

ping...

is this project dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant