Skip to content

fix: login email should be case insensitive #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: login email should be case insensitive #1911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/auth/email/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

const Router = require('express').Router
const passport = require('passport')
const sequelize = require('sequelize')
const validator = require('validator')
const LocalStrategy = require('passport-local').Strategy
const config = require('../../config')
Expand All @@ -21,7 +22,11 @@ passport.use(new LocalStrategy({
try {
const user = await models.User.findOne({
where: {
email: email
email: sequelize.where(
sequelize.fn('LOWER', sequelize.col('email')),
'LIKE',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to use LIKE operator here, compare directly will be fine.

`%${email.toLowerCase()}%`
)
}
})

Expand Down