-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Cheater command + spoiler improvement #133
[FEATURE] - Cheater command + spoiler improvement #133
Conversation
…spoiler to use the helper with a new data type. Altered config + added testing
@dimoschi We'll be reusing the existing Jira webhook URL but the name of the variable changes now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We must ensure to update the env name to JIRA_WEBHOOK
on the CI/CD
d1ef8d4
to
e5f78ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor issue that this PR does more than one thing, improving the cheater/spoiler feature and adding a new Academy Role.
You're right - small issue in the .test.env - but this should already be added as we merged it in #132 |
New command
/cheater
to allow users to report cheaters on the main platform.We also add a new field 'desc' to the spoiler command and made the url field required.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply.Proposed changes
/cheater
command to report cheaters on main platform with a cooldown.spoiler
andcheater
to the webhook.test.env
("JIRA_SPOILER_WEBHOOK” to “JIRA_WEBHOOK”)/cheater
spoiler
/spoiler
([FEATURE] Added description field to spoiler and made the url field required #134)Checklist
Put an
x
in the boxes that apply.doc.
Additional context