Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Cheater command + spoiler improvement #133

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

janssensjelle
Copy link
Contributor

@janssensjelle janssensjelle commented Dec 27, 2024

New command /cheater to allow users to report cheaters on the main platform.
We also add a new field 'desc' to the spoiler command and made the url field required.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

…spoiler to use the helper with a new data type.  Altered config + added testing
@ToxicBiohazard
Copy link
Contributor

@dimoschi We'll be reusing the existing Jira webhook URL but the name of the variable changes now JIRA_WEBHOOK.

Copy link
Contributor

@ToxicBiohazard ToxicBiohazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We must ensure to update the env name to JIRA_WEBHOOK on the CI/CD

@janssensjelle janssensjelle changed the title [FEATURE] - Cheater command [FEATURE] - Cheater command + spoiler improvement Jan 19, 2025
Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor issue that this PR does more than one thing, improving the cheater/spoiler feature and adding a new Academy Role.

@janssensjelle
Copy link
Contributor Author

LGTM. Minor issue that this PR does more than one thing, improving the cheater/spoiler feature and adding a new Academy Role.

You're right - small issue in the .test.env - but this should already be added as we merged it in #132

@dimoschi dimoschi merged commit 07fceb7 into hackthebox:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants