feat: ✨ update auth middlewares to allow other auth middlewares #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jontsai
requested changes
Feb 12, 2025
Comment on lines
+127
to
+128
| """Custom Authentication Middleware to attempt logging in with a securely generated | ||
| token |
There was a problem hiding this comment.
Suggested change
| """Custom Authentication Middleware to attempt logging in with a securely generated | |
| token | |
| """Custom Authentication Middleware to attempt logging in with | |
| a securely generated token |
Can we break the text differently? Break before the phrase
Comment on lines
+169
to
+170
| However, if user is logged in when the exception occurred, it is a connection | ||
| failure. Therefore, always go to account settings page or equivalent |
There was a problem hiding this comment.
Suggested change
| However, if user is logged in when the exception occurred, it is a connection | |
| failure. Therefore, always go to account settings page or equivalent | |
| However, if user is logged in when the exception occurred, | |
| it is a connection failure. | |
| Therefore, always go to account settings page or equivalent |
Let's break the text differently. New sentence on new line...
| @@ -95,10 +100,10 @@ def set_random_password(user, password_length=16): | |||
|
|
|||
| def email_to_username_hash(email): | |||
| """Convert emails to hashed versions where we store them in the username field | |||
| We can't just store them directly, or we'd be limited to Django's username <= 30 chars limit, | |||
| which is really too small for arbitrary emails | |||
| We can't just store them directly, or we'd be limited to Django's username <= 30 | |||
There was a problem hiding this comment.
please revert, this is breaking docstrings in the middle of the thought/phrase, and makes the docstring harder to understand.
| @@ -175,7 +180,7 @@ def get_user_by_email(email): | |||
| ) | |||
| except UserModel.MultipleObjectsReturned: | |||
| user = None | |||
| request = get_current_request() | |||
| request = get_current_request() # noqa: F841 | |||
There was a problem hiding this comment.
I don't think F841 is the right one. Why?
I think below needs to get updated to:
rollbar.report_exc_info(request=request) ?
Let's double check against other places.
| except: | ||
| request = get_current_request() | ||
| except Exception: | ||
| request = get_current_request() # noqa: F841 |
There was a problem hiding this comment.
same, change below to rollbar.report_exc_info(request=request)
| @@ -304,7 +309,7 @@ def get_user_email(user, email, is_confirmed=True): | |||
| return user_email | |||
|
|
|||
|
|
|||
| def associate_user_email( | |||
| def associate_user_email( # noqa: C901 | |||
There was a problem hiding this comment.
| else: | ||
| # No authentication token provided via available methods | ||
| token = None | ||
| # and give a chance for other auth middlewares to work |
There was a problem hiding this comment.
Suggested change
| # and give a chance for other auth middlewares to work | |
| # give a chance for other auth middlewares to work |
| # unexpected authorization value | ||
| token = None | ||
| auth_user = authenticate(request=request, token=token) | ||
|
|
||
| elif 'token' in request.GET: | ||
| # implicit authenication token using URL params |
There was a problem hiding this comment.
Suggested change
| # implicit authenication token using URL params | |
| # implicit authentication token using URL params |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this PR is to give room to custom authentication middlewares in the projects.
The middlewares were cutting off the execution and giving forbidden errors other than the
BearerandBasicauth token types.Also getting the
token_typeandtokenfromHTTP_AUTHORIZATIONis made a utility function to keep the code DRY.