-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new data table style #718
Conversation
To avoid confusion with the new category function in data tables
Co-authored-by: Joakim Sørensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise it seems ok for me. I will pull the repository to do functional tests 🙂
src/localize/languages/en.json
Outdated
"column": { | ||
"name": "Repository Name", | ||
"downloads": "Downloads", | ||
"stars": "Stars", | ||
"installed_version": "Downloaded version", | ||
"available_version": "Available version", | ||
"status": "Status", | ||
"category": "Category", | ||
"category": "Type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the key to type
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably be changed in the backend too, to align it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes in my dev instance and I don't see any issue. It works well 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Use the new data table style, moves the content of the filter dialog to the filter pane.
Adds grouping by state and type.
Removes the default filtering by downloaded and removing the filter when starting to search.
Removes the FAB and dialog saying it has been removed.
Filters will be updated in a follow up PR