Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new data table style #718

Merged
merged 23 commits into from
May 8, 2024
Merged

Conversation

bramkragten
Copy link
Contributor

@bramkragten bramkragten commented Apr 14, 2024

Use the new data table style, moves the content of the filter dialog to the filter pane.
Adds grouping by state and type.
Removes the default filtering by downloaded and removing the filter when starting to search.
Removes the FAB and dialog saying it has been removed.

Filters will be updated in a follow up PR

CleanShot 2024-04-17 at 12 37 36

CleanShot 2024-04-17 at 12 38 17

Copy link

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it seems ok for me. I will pull the repository to do functional tests 🙂

"column": {
"name": "Repository Name",
"downloads": "Downloads",
"stars": "Stars",
"installed_version": "Downloaded version",
"available_version": "Available version",
"status": "Status",
"category": "Category",
"category": "Type",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the key to type ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be changed in the backend too, to align it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

src/dashboards/hacs-dashboard.ts Outdated Show resolved Hide resolved
Copy link

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes in my dev instance and I don't see any issue. It works well 🙂

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ludeeus ludeeus merged commit ce7dba2 into hacs:main May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants