Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync core to 7f50504 #751

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Sync core to 7f50504 #751

merged 2 commits into from
Jul 5, 2024

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jul 5, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Walkthrough

Walkthrough

Whoa, we’ve got quite the makeover here! This set of changes primarily bumps up dependency versions, tweaks localization handling, and adds scripts for better automation. The shining star, though, is our new and improved translations script that merges translations like a synergy guru. We see localization functionality shifting gears from hass to hacs, and a sprinkle of dynamic imports for good measure. Overall, it's a neat blend of updates and new features ensuring smoother functionality.

Changes

File(s) Change Summary
homeassistant-frontend Updated subproject commit hash.
package.json Version upgrades for multiple dependencies including @lokalise/node-api, typescript, and more.
script/bootstrap Added invocation of the new inject_translations.js script.
script/inject_translations.js Introduced a script to import, merge and write translations from/to JSON files.
src/dashboards/hacs-dashboard.ts Switched localization function context from hass.localize to hacs.localize. Updated labels.
src/entrypoint.ts Changed to dynamically import setCancelSyntheticClickEvents().
src/localize/languages/en.json Added new keys for "actions" and "icon" under "column", and new UI components in the "ui" section.

Sequence Diagram(s)

Silently ignoring sequence diagrams for this task, like a ninja avoiding detection in plain sight! 🐱‍👤


Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between cbe4ad9 and d821808.

Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing (7)
  • homeassistant-frontend (1 hunks)
  • package.json (6 hunks)
  • script/bootstrap (1 hunks)
  • script/inject_translations.js (1 hunks)
  • src/dashboards/hacs-dashboard.ts (3 hunks)
  • src/entrypoint.ts (1 hunks)
  • src/localize/languages/en.json (2 hunks)
Additional context used
Biome
script/inject_translations.js

[error] 1-1: A Node.js builtin module should be imported with the node: protocol.

Using the node: protocol is more explicit and signals that the imported module belongs to Node.js.
Unsafe fix: Add the node: protocol.

(lint/style/useNodejsImportProtocol)


[error] 2-3: This let declares a variable that is only assigned once.

'rawcore' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)


[error] 3-4: This let declares a variable that is only assigned once.

'rawhacs' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

Additional comments not posted (10)
homeassistant-frontend (1)

1-1: LGTM! Subproject commit hash updated.

The commit hash update looks good. No issues here!

script/bootstrap (1)

10-10: Nice addition!

Including the inject_translations.js script before yarn install is a smart move. This ensures that translations are up-to-date before dependencies are installed.

script/inject_translations.js (1)

9-23: LGTM! Code for merging translations looks solid.

The logic for reading, merging, and writing JSON translation data is well-implemented. Just a couple of tweaks needed as mentioned above.

src/entrypoint.ts (1)

9-11: Dynamic import looks good!

The dynamic import of setCancelSyntheticClickEvents is a nice touch. No issues here.

src/localize/languages/en.json (2)

29-33: Nice additions!

The new keys "actions" and "icon" enhance the UI components' clarity and functionality. Keep up the good work!


136-156: Great job on the new section!

The new "ui.components.subpage-data-table" section adds detailed localization for data table functionalities, which will definitely improve user experience. Nice touch!

package.json (2)

Line range hint 27-70:
Dependency updates look solid!

The updates for @lokalise/node-api, @typescript-eslint packages, eslint-plugin-lit-a11y, and typescript are all good to go. Keeping dependencies up-to-date is always a wise move. Kudos!


Line range hint 125-172:
More dependency updates!

The updates for @codemirror/view and @material/web look good. Keep those dependencies fresh!

src/dashboards/hacs-dashboard.ts (2)

116-116: Localization function update looks good!

The update from this.hass.localize to this.hacs.localize is correct and aligns with the new structure. Nice work!


Line range hint 266-381:
Column labels updated nicely!

The column labels now use the new localization function references, which is a great improvement. Everything looks shipshape!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

script/inject_translations.js Show resolved Hide resolved
script/inject_translations.js Show resolved Hide resolved
@ludeeus ludeeus merged commit c4b88ae into main Jul 5, 2024
3 checks passed
@ludeeus ludeeus deleted the synccore7f50504 branch July 5, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant