Skip to content

Commit

Permalink
Don't exit early if force for update_repository (#2434)
Browse files Browse the repository at this point in the history
  • Loading branch information
ludeeus authored Jan 8, 2022
1 parent c7f1c42 commit f03b534
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 6 deletions.
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/appdaemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from ..enums import HacsCategory
from ..exceptions import HacsException
from ..utils.decorator import concurrent
from .base import HacsRepository

if TYPE_CHECKING:
Expand Down Expand Up @@ -57,9 +58,10 @@ async def validate_repository(self):
self.logger.error("%s %s", self, error)
return self.validate.success

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

# Get appdaemon objects.
Expand Down
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from ..enums import HacsCategory, HacsGitHubRepo, RepositoryFile
from ..exceptions import HacsException
from ..utils.decode import decode_content
from ..utils.decorator import concurrent
from ..utils.filters import get_first_directory_in_directory
from ..utils.version import version_to_download
from .base import HacsRepository
Expand Down Expand Up @@ -97,9 +98,10 @@ async def validate_repository(self):
self.logger.error("%s %s", self, error)
return self.validate.success

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

if self.data.content_in_root:
Expand Down
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/netdaemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from ..enums import HacsCategory
from ..exceptions import HacsException
from ..utils import filters
from ..utils.decorator import concurrent
from .base import HacsRepository

if TYPE_CHECKING:
Expand Down Expand Up @@ -61,9 +62,10 @@ async def validate_repository(self):
self.logger.error("%s %s", self, error)
return self.validate.success

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

# Get appdaemon objects.
Expand Down
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from typing import TYPE_CHECKING

from ..exceptions import HacsException
from ..utils.decorator import concurrent
from .base import HacsRepository

if TYPE_CHECKING:
Expand Down Expand Up @@ -51,9 +52,10 @@ async def validate_repository(self):
self.logger.error("%s %s", self, error)
return self.validate.success

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

# Get plugin objects.
Expand Down
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/python_script.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from ..enums import HacsCategory
from ..exceptions import HacsException
from ..utils.decorator import concurrent
from .base import HacsRepository

if TYPE_CHECKING:
Expand Down Expand Up @@ -62,9 +63,10 @@ async def async_post_registration(self):
# Set name
self.update_filenames()

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

# Get python_script objects.
Expand Down
4 changes: 3 additions & 1 deletion custom_components/hacs/repositories/theme.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from ..enums import HacsCategory
from ..exceptions import HacsException
from ..utils.decorator import concurrent
from .base import HacsRepository

if TYPE_CHECKING:
Expand Down Expand Up @@ -68,9 +69,10 @@ async def async_post_registration(self):
self.update_filenames()
self.content.path.local = self.localpath

@concurrent(concurrenttasks=10, backoff_time=5)
async def update_repository(self, ignore_issues=False, force=False):
"""Update."""
if not await self.common_update(ignore_issues, force):
if not await self.common_update(ignore_issues, force) and not force:
return

# Get theme objects.
Expand Down

0 comments on commit f03b534

Please sign in to comment.